Change timestamp naming#178
Merged
flora-hofmann-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom May 12, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors timestamp-related parameter names by replacing "start_dt" and "end_dt" with "start_time" and "end_time" for improved clarity and consistency across the codebase.
- Renames function parameters and arguments in both the CLI and client modules.
- Updates docstrings and release notes to reflect the new naming.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frequenz/client/reporting/cli/main.py | Updated argument names and corresponding parameter names in the CLI module. |
| src/frequenz/client/reporting/_client.py | Updated all timestamp parameter names and related docstrings in client code. |
| RELEASE_NOTES.md | Updated release notes to document the parameter name changes. |
Signed-off-by: Flora <flora.hofmann@frequenz.com>
flora-hofmann-frequenz
force-pushed
the
change_timestamps
branch
from
050a0e4 to
3000f87
Compare
cwasicki
approved these changes
May 12, 2025
flora-hofmann-frequenz
merged commit b7845fc
into
frequenz-floss:v0.x.x
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed comments from #169 and #176.